Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump long from 4.0.0 to 5.0.0 #797

Closed
wants to merge 4 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2021

Bumps long from 4.0.0 to 5.0.0.

Release notes

Sourced from long's releases.

v5.0.0

Breaking changes

  • Switch to ESM / modernize (86410397c36ad64aa6c9a45293bff918ce0ea14d)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [long](https://github.com/dcodeIO/long.js) from 4.0.0 to 5.0.0.
- [Release notes](https://github.com/dcodeIO/long.js/releases)
- [Commits](dcodeIO/long.js@4.0.0...v5.0.0)

---
updated-dependencies:
- dependency-name: long
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner October 28, 2021 17:01
@dependabot dependabot bot added the Update dependencies Trigger PR workflow to update dependencies label Oct 28, 2021
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Oct 28, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 28, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@aeisenberg
Copy link
Contributor

Oh...this isn't cool. long is now using js modules and breaking our build. The workflow is using node 14.8, so it should recognize js modules. There's probably some sort of flag we are not using.

@aeisenberg
Copy link
Contributor

Unfortunately, I don't see any way we can get this working unless we migrate to using mjs for all of our modules, but that causes a whole whack of other problems.

We may need to look for a new library to use or see if there is a non-mjs version of long that is safe.

@aeisenberg
Copy link
Contributor

There is now (or will be soon) a UMD fallback for long.js. See dcodeIO/long.js#104 We should wait a few days to upgrade until this is officially released.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 4, 2021

A newer version of long exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@aeisenberg
Copy link
Contributor

OK...UMD fallback now available in 5.1.0.

@henrymercer henrymercer added the Update dependencies Trigger PR workflow to update dependencies label Jan 31, 2022
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Jan 31, 2022
@henrymercer
Copy link
Contributor

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 31, 2022

Superseded by #901.

@dependabot dependabot bot closed this Jan 31, 2022
auto-merge was automatically disabled January 31, 2022 18:32

Pull request was closed

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/long-5.0.0 branch January 31, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants