Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn re:status for official octokit libraries #16718

Merged
merged 2 commits into from Apr 6, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 31, 2022

Why:

#14926 (comment)

What's being changed:

Adding a warning about maintenance status.

image

Note: I chose not to mention the announcement bit as it seems there was one of sorts later, and I don't think it's helpful to someone investigating the state of libraries. That said, I'm happy to let someone merge in any content changes they wish.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/rest/overview/libraries.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review rest Content related to rest - overview. and removed triage Do not begin working on this issue until triaged by the team labels Apr 1, 2022
@ramyaparimi
Copy link
Contributor

@jsoref
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition! We'll get it merged down for you.

@skedwards88 skedwards88 enabled auto-merge (squash) April 6, 2022 18:13
@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Apr 6, 2022
@docubot docubot added this to Triage in Docs open source board Apr 6, 2022
@skedwards88 skedwards88 merged commit 1581113 into github:main Apr 6, 2022
Docs open source board automation moved this from Triage to Done Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jsoref jsoref deleted the octokit-unmaintained branch April 6, 2022 18:37
Copy link

@PandaSuits PandaSuits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge rest Content related to rest - overview.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants