Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 add note about future SDK team #17072

Merged
merged 4 commits into from
Apr 18, 2022
Merged

📝 add note about future SDK team #17072

merged 4 commits into from
Apr 18, 2022

Conversation

JoshuaTheMiller
Copy link
Contributor

@JoshuaTheMiller JoshuaTheMiller commented Apr 14, 2022 •
edited

Why:

There has been some concern across communities regarding the Warning on the GitHub API Library page (the text being modified by this PR).

References (not closes): #14926
References: octokit/octokit.js#620

What's being changed:

This adds some detail and a link around the future of the SDK teams and a link to an official announcement.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).

image

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@JoshuaTheMiller
📝 add note about future SDK team
7bc9bc1 
* Reference: octokit/octokit.js#620
* Adding this as the original warning has caused some confusion and concern around the community.
@welcome
Copy link

welcome bot commented Apr 14, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2022 •
edited

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/rest/overview/libraries.md Modified Original

@JoshuaTheMiller
Copy link
Contributor Author

My original wording is admittedly a bit on the cheesy side, but I wanted to get this ball rolling. Please don't hesitate to suggest alternatives if the basis of this change seems valid!

@JoshuaTheMiller JoshuaTheMiller marked this pull request as ready for review April 14, 2022 03:03
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review rest Content related to rest - overview. and removed triage Do not begin working on this issue until triaged by the team labels Apr 14, 2022
@ramyaparimi
Copy link
Contributor

@JoshuaTheMiller
Thanks so much for opening a PR! I'll get this triaged for review ⚡

skedwards88
skedwards88 reviewed Apr 18, 2022
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this additional reference! I'm going to modify the wording to fit the docs style, then we'll get this merged down for you.

content/rest/overview/libraries.md Outdated Show resolved Hide resolved
@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Apr 18, 2022
@skedwards88 skedwards88 enabled auto-merge (squash) April 18, 2022 16:06
@docubot docubot added this to Triage in Docs open source board Apr 18, 2022
@skedwards88 skedwards88 merged commit 0e30279 into github:main Apr 18, 2022
Docs open source board automation moved this from Triage to Done Apr 18, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@JoshuaTheMiller JoshuaTheMiller deleted the patch-2 branch October 6, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge rest Content related to rest - overview.
Projects
Docs open source board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshuaTheMiller @ramyaparimi @skedwards88