Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct standard peer dependencies #27425

Conversation

voxpelli
Copy link

Why:

dependabot can not help with updating from unmaintained modules to maintained forks, that needs manual intervention. This replaces the unmaintained (and for eslint-config-standard incorrect) eslint-plugin-node with the eslint-plugin-n fork that's maintained by the official ESLint Community org.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Replace eslint-plugin-node with the now used official fork eslint-plugin-n.

Also update to latest version of eslint-config-standard and its peer dependencies.

Since it can be hard for users of eslint-plugin-node to find out that there's a maintained fork from the official ESLint Community project I'm doing a drive where I'm making PR:s to some projects to raise awareness.

See: eslint-community/eslint-plugin-n#100

Disclaimer: I'm a co-maintainer of both standard and eslint-plugin-n

Check off the following:

Not applicable for this

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Replace `eslint-plugin-node` with the now used official fork `eslint-plugin-n`.

Also update to latest version of `eslint-config-standard` and its peer dependencies.

Since it can be hard for users of `eslint-plugin-node` to find out that there's a maintained fork from the official [ESLint Community project](https://github.com/eslint-community) I'm doing a drive where I'm making PR:s to some projects to raise awareness.

See: eslint-community/eslint-plugin-n#100

Disclaimer: I'm a co-maintainer of both `standard` and `eslint-plugin-n`
@welcome
Copy link

welcome bot commented Aug 13, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
src/**
lib/redirects/**
package*.json
scripts/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 13, 2023
@peterbe
Copy link
Contributor

peterbe commented Aug 14, 2023

Hej hej @voxpelli Thanks for the PR.

The public github/docs repo is a copy of the private github/docs-internal repo which is where we do code changes. We do this for the sake of security. This way PR contributions to this public repo needs to be about content changes. But every now and then excellent OSS citizens like yourself come along and help out. Super appreciate it!
I'll copy this PR to our private repo and make sure it gets tested there first. Then it'll trickle in to this public repo.

Tack för hjälpen!

@voxpelli
Copy link
Author

@peterbe Makes sense, tack!

@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Aug 14, 2023
@cmwilson21
Copy link
Contributor

@voxpelli Thanks for submitting this PR! Looks like the PR @peterbe submitted internally has been merged and the changes are now live in the repo. So I'm going to go ahead and close this out ✨

Thank you again for raising this! We appreciate your contribution to the docs!

@cmwilson21 cmwilson21 closed this Aug 14, 2023
@voxpelli voxpelli deleted the voxpelli/switch-to-maintained-eslint-plugin-n branch August 14, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants