Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling in scripts: e.g. means exempli gratia #31980

Closed
wants to merge 1 commit into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 6, 2024

Why:

Because the notice on https://github.com/github/docs/pull/31974/files bothers me -- it's wrong.

image

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • src/search/scripts/analyze-text.js
  • src/search/scripts/index-elasticsearch.js

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/workflows/**
  • .github/CODEOWNERS
  • assets/fonts/**
  • data/graphql/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/*/scripts/**
  • src/**.json
  • src/workflows/**
  • lib/redirects/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

@jsoref
Copy link
Contributor Author

jsoref commented Mar 6, 2024

Could someone please take this to engineering and merge it on the internal side?

@nguyenalex836 nguyenalex836 added fix-internally Triggers a workflow to copy the issue internally and close the current issue content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Mar 6, 2024
@nguyenalex836 nguyenalex836 marked this pull request as ready for review March 6, 2024 21:43
@nguyenalex836 nguyenalex836 added fix-internally Triggers a workflow to copy the issue internally and close the current issue and removed fix-internally Triggers a workflow to copy the issue internally and close the current issue labels Mar 6, 2024
@nguyenalex836
Copy link
Contributor

@jsoref 👋 I've filed an internal issue to have this addressed

@nguyenalex836 nguyenalex836 added fixing internally This will be fixed internally and removed fix-internally Triggers a workflow to copy the issue internally and close the current issue labels Mar 6, 2024
@jsoref jsoref deleted the scripts-exempli-gratia branch March 6, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team fixing internally This will be fixed internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants