Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling e.g. means exempli gratia #31981

Merged
merged 3 commits into from Mar 9, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 6, 2024

Why:

e.g. should be spelled as such, in https://docs.github.com/en/site-policy/content-removal-policies/dmca-takedown-policy

What's being changed (if available, include any code snippets, screenshots, or gifs):

Before

https://docs.github.com/en/site-policy/content-removal-policies/dmca-takedown-policy#learn-more-and-speak-up
image

After

https://docs-31981-8420cc.preview.ghdocs.com/en/site-policy/content-removal-policies/dmca-takedown-policy#learn-more-and-speak-up
image

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
site-policy/content-removal-policies/dmca-takedown-policy.md fpt
fpt

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836
Copy link
Contributor

@jsoref Hello! 👋 Let us know once this PR is ready for review

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team site policy Content related to site policy more-information-needed More information is needed to complete review and removed triage Do not begin working on this issue until triaged by the team labels Mar 7, 2024
@jsoref jsoref marked this pull request as ready for review March 7, 2024 21:14
@jsoref jsoref requested a review from a team as a code owner March 7, 2024 21:14
@jsoref
Copy link
Contributor Author

jsoref commented Mar 8, 2024

@nguyenalex836 this is ready

@nguyenalex836
Copy link
Contributor

@jsoref Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing, and our Site Policy team gives their approval 🍏

@nguyenalex836
Copy link
Contributor

Internal: requested review from Site Policy team here

Copy link
Contributor

@khxu khxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t.y.! 😄

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Mar 9, 2024
Merged via the queue into github:main with commit a45bc82 Mar 9, 2024
40 checks passed
Copy link
Contributor

github-actions bot commented Mar 9, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jsoref jsoref deleted the spelling-dmca-exempli-gratia branch March 10, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review site policy Content related to site policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants