Skip to content

Commit

Permalink
Merge pull request #325 from github/update-eslint-plugin-escompat
Browse files Browse the repository at this point in the history
Update eslint plugin escompat
  • Loading branch information
koddsson committed Oct 11, 2022
2 parents 60d8ecc + 22e10ae commit d2aaaef
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 10 deletions.
2 changes: 1 addition & 1 deletion lib/configs/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module.exports = {
browser: true
},
plugins: ['github', 'escompat'],
extends: ['plugin:escompat/recommended', 'plugin:escompat/typescript'],
extends: ['plugin:escompat/recommended'],
rules: {
'escompat/no-dynamic-imports': 'off',
'github/async-currenttarget': 'error',
Expand Down
2 changes: 1 addition & 1 deletion lib/configs/typescript.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = {
extends: ['plugin:@typescript-eslint/recommended', 'prettier'],
extends: ['plugin:@typescript-eslint/recommended', 'prettier', 'plugin:escompat/typescript-2020'],
parser: '@typescript-eslint/parser',
plugins: ['@typescript-eslint', 'github'],
rules: {
Expand Down
25 changes: 18 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@
},
"homepage": "https://github.com/github/eslint-plugin-github#readme",
"dependencies": {
"@github/browserslist-config": "^1.0.0",
"@typescript-eslint/eslint-plugin": "^5.1.0",
"@typescript-eslint/parser": "^5.1.0",
"eslint-config-prettier": ">=8.0.0",
"eslint-plugin-escompat": "^3.1.0",
"eslint-plugin-escompat": "^3.3.3",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-filenames": "^1.3.2",
"eslint-plugin-i18n-text": "^1.0.1",
Expand All @@ -42,6 +43,7 @@
"svg-element-attributes": "^1.3.1"
},
"prettier": "@github/prettier-config",
"browserslist": "@github/browserslist-config",
"peerDependencies": {
"eslint": "^8.0.1"
},
Expand Down

0 comments on commit d2aaaef

Please sign in to comment.