Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ballerina.gitignore #4431

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

Ramith-D-Rodrigo
Copy link
Contributor

Reasons for making this change:
Currently, there are no gitignore files for Ballerina language.

Links to documentation supporting these rule changes:
Learn Ballerina

Ballerina project directory structure contains directories named target and generated.

  • target is used to store jars, cached files (such as jsons), docs, etc when a specific bal command is executed.
  • generated directory is used to store generated .bal files. (Ex: store data model's client API which is generated during by bal persist generate)

Config.toml is used to store secrets/configurable variable values.

If this is a new template:

@Ramith-D-Rodrigo
Copy link
Contributor Author

@bdougie Hi, is it possible to get this merged?

@Ramith-D-Rodrigo
Copy link
Contributor Author

@wirecat Hi, would be much apprieciated if you can take a look and get it merged.

Comment on lines 1 to 8
# vscode files
.vscode/

# intellij files
.idea/

# mac
.DS_Store
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be open to removing these lines? These are handled by globals.

We prefer to keep the templates very tightly focused on the language/tool in question.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! thanks for pointing that out. I have made the relevant changes in 3af7bb0. Pls take a look

@wirecat wirecat merged commit 745b639 into github:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants