Added an Express.gitignore file to my own branch named my-own-branch - by / chprince11 #4432
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wirecat
requested changes
May 29, 2024
Comment on lines
+32
to
+36
| # Mac OS files | ||
| .DS_Store | ||
|
|
||
| # Windows thumbnail cache files | ||
| Thumbs.db |
There was a problem hiding this comment.
Please remove as we don't accept OS specific rules in template files unless they're added to the OS specific template in Global.
See macOS.gitignore for an example.
🙇
There was a problem hiding this comment.
Could you provide a little more detail on Express and references backing up your choices in the ignore template?
Official docs and/or examples of popular Express .gitignore files are good options.
There was a problem hiding this comment.
Yes, sir. Of course, I will make the changes soon, maybe tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
Here, I will going to explain why I have made this change. For example, if you're updating the '.gitignore' file, you might say something like "Updated '.gitignore' to ignore log files and node_modules directory for cleaner repository."
Links to documentation supporting these rule changes:
https://expressjs.com/ |
https://git-scm.com/docs/gitignore |
https://flatirons.com/blog/understanding-and-implementing-gitignore-for-node_modules/ |