Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows Dev Experience: fix npm commands (cross-env package), fix Source Control Repos, and document all #200

Merged
merged 18 commits into from May 23, 2023

Conversation

KetchupOnMyKetchup
Copy link
Contributor

@KetchupOnMyKetchup KetchupOnMyKetchup commented May 22, 2023

Resolves #89

--

Fix so that npm commands to work in Windows:

  1. Add cross-env package to vscode main project
  2. Escape with slashes in package.json: format, format-check, and test

Updates to Contributing.md doc

  1. Reorganize and rewrite the Dev loop & Testing changes section to be more clear
  2. Note use of cross-env package
  3. Removing $ from commands to make copy/paste easier and indicate it works on Windows as well
  4. Add specific notes about which directory to run npm commands
  5. Add instructions and screenshot for adding both repos to Source Control Repositories

Fixed Source Control Repositories (before it only showed vscode-github-actions and not language services), figured out from this issue:
image

Screenshots from Windows BEFORE changes (broken state):

image

Screenshots from Windows to show that it works still after changes:

image

Screenshots from Mac to show that it works still after changes:

image

image

image

image

@KetchupOnMyKetchup KetchupOnMyKetchup changed the title Add cross-env to vscode main project and escape format, format-check,… Add cross-env and escape npm commands so dev environment works better in Windows May 22, 2023
@KetchupOnMyKetchup KetchupOnMyKetchup changed the title Add cross-env and escape npm commands so dev environment works better in Windows Add cross-env package and escape npm commands so dev environment works better in Windows May 22, 2023
@KetchupOnMyKetchup KetchupOnMyKetchup changed the title Add cross-env package and escape npm commands so dev environment works better in Windows Improve Windows Dev Experience: fix npm commands (cross-env package), fix Source Control Repos, and document all May 22, 2023
@KetchupOnMyKetchup KetchupOnMyKetchup marked this pull request as ready for review May 22, 2023 19:31
@KetchupOnMyKetchup KetchupOnMyKetchup requested a review from a team as a code owner May 22, 2023 19:31
felipesu19
felipesu19 previously approved these changes May 22, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
jtamsut
jtamsut previously approved these changes May 22, 2023
Copy link
Contributor

@jtamsut jtamsut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-blocking questions/comments

felipesu19
felipesu19 previously approved these changes May 22, 2023
cschleiden
cschleiden previously approved these changes May 23, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Christopher Schleiden <cschleiden@github.com>
KetchupOnMyKetchup and others added 5 commits May 22, 2023 20:32
Co-authored-by: Christopher Schleiden <cschleiden@github.com>
Co-authored-by: Christopher Schleiden <cschleiden@github.com>
Co-authored-by: Christopher Schleiden <cschleiden@github.com>
@KetchupOnMyKetchup KetchupOnMyKetchup merged commit 3b9190e into main May 23, 2023
2 checks passed
@KetchupOnMyKetchup KetchupOnMyKetchup deleted the ketchup/windowsDevExperience branch May 23, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve dev experience work for Windows and Codespaces + Document changes
5 participants