Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest base images. #1334

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

anotherbridge
Copy link
Contributor

Description:

The current Dockerfile uses the golang image of version 1.19 which is deprecated (c.f. https://endoflife.date/go) as well as the alpine image version 3.16 which is soon going to be deprecated (https://endoflife.date/alpine).
To always have the latest patched versions this PR changes the images to latest. If this is not desired, I would recommend that we at least use the latest version explicitly and update it.

@zricethezav
Copy link
Collaborator

Hi @anotherbridge, thanks for the PR.

If this is not desired, I would recommend that we at least use the latest version explicitly and update it.

I'd feel better pinning a version

@anotherbridge
Copy link
Contributor Author

Thanks @zricethezav I fixed it to the latest major version.

@zricethezav zricethezav merged commit 8d23afd into gitleaks:master Feb 2, 2024
1 check passed
@omercnet
Copy link

can we get a version bump to include this change ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants