Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some passwords are treated as false negatives #1336

Closed
wants to merge 2 commits into from
Closed

Some passwords are treated as false negatives #1336

wants to merge 2 commits into from

Conversation

rdiezsj
Copy link

@rdiezsj rdiezsj commented Feb 6, 2024

Description:

The "generic-api-key" is modified to take into account the "/" and "+" symbols, since they are very common and with the current rule are causing false negatives.

An example password that would be correctly detected and currently is not:

sasl_password=LIkaITK744sG54VgABW/+p4NXFr

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@rgmz
Copy link
Contributor

rgmz commented Feb 6, 2024

The "generic-api-key" is modified to take into account the "/" and "+" symbols, since they are very common

To give a specific example: "/" and "+" are base64 characters, meaning that any base64-encoded secrets won't be detected.

@rdiezsj
Copy link
Author

rdiezsj commented Feb 7, 2024

With these changes, base64-encoded secrets are now detected, avoiding the generation of false negatives

@rdiezsj rdiezsj closed this by deleting the head repository Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants