Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope flag to idp commands #19727

Merged
merged 2 commits into from May 15, 2024
Merged

Add scope flag to idp commands #19727

merged 2 commits into from May 15, 2024

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented May 10, 2024

Description

Related Issue(s)

Fixes ENT-34

How to test

idp aws regression tests

curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
unzip awscliv2.zip
sudo ./aws/install
  • Log into AWS, and check functionalities working
gp idp login aws --scope foo --role-arn=arn:aws:iam::745721252581:role/gitpod-test
aws sts get-caller-identity
  • Repeat the same steps with other repo, it should failed
gitpod-samples/spring-petclinic gitpod-io/empty
image image
Setting of `arn:aws:iam::745721252581:role/gitpod-test`

img

idp token

  • Exec command below should found scope field is included in output
gp idp token --audience foo --scope bar | jq -R 'split(".") | .[0],.[1] | @base64d | fromjson'
Img
image

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh mustard-mh marked this pull request as ready for review May 13, 2024 18:41
@mustard-mh mustard-mh requested a review from a team as a code owner May 13, 2024 18:41
Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm 🎉

@roboquat roboquat merged commit 5ff4535 into main May 15, 2024
39 of 40 checks passed
@roboquat roboquat deleted the hw/ENT-34 branch May 15, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants