Drop unneeded flake8 suppressions #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Remove the comments that documented those old suppressions + Format the .flake8 file more readably
Byron
approved these changes
Sep 27, 2023
renovate bot
added a commit
to allenporter/flux-local
that referenced
this pull request
Oct 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [GitPython](https://togithub.com/gitpython-developers/GitPython) | `==3.1.37` -> `==3.1.40` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>gitpython-developers/GitPython (GitPython)</summary> ### [`v3.1.40`](https://togithub.com/gitpython-developers/GitPython/compare/3.1.38...3.1.40) [Compare Source](https://togithub.com/gitpython-developers/GitPython/compare/3.1.38...3.1.40) ### [`v3.1.38`](https://togithub.com/gitpython-developers/GitPython/releases/tag/3.1.38) [Compare Source](https://togithub.com/gitpython-developers/GitPython/compare/3.1.37...3.1.38) #### What's Changed - Add missing assert keywords by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1678 - Make clear every test's status in every CI run by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1679 - Fix new link to license in readme by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1680 - Drop unneeded flake8 suppressions by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1681 - Update instructions and test helpers for git-daemon by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1684 - Fix Git.execute shell use and reporting bugs by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1687 - No longer allow CI to select a prerelease for 3.12 by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1689 - Clarify Git.execute and Popen arguments by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1688 - Ask git where its daemon is and use that by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1697 - Fix bugs affecting exception wrapping in rmtree callback by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1700 - Fix dynamically-set **all** variable by [@​DeflateAwning](https://togithub.com/DeflateAwning) in [gitpython-developers/GitPython#1659 - Fix small [#​1662](https://togithub.com/gitpython-developers/GitPython/issues/1662) regression due to [#​1659](https://togithub.com/gitpython-developers/GitPython/issues/1659) by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1701 - Drop obsolete info on yanking from security policy by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1703 - Have Dependabot offer submodule updates by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1702 - Bump git/ext/gitdb from `49c3178` to `8ec2390` by [@​dependabot](https://togithub.com/dependabot) in [gitpython-developers/GitPython#1704 - Bump git/ext/gitdb from `8ec2390` to `6a22706` by [@​dependabot](https://togithub.com/dependabot) in [gitpython-developers/GitPython#1705 - Update readme for milestone-less releasing by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1707 - Run Cygwin CI workflow commands in login shells by [@​EliahKagan](https://togithub.com/EliahKagan) in [gitpython-developers/GitPython#1709 #### New Contributors - [@​DeflateAwning](https://togithub.com/DeflateAwning) made their first contribution in [gitpython-developers/GitPython#1659 **Full Changelog**: gitpython-developers/GitPython@3.1.37...3.1.38 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
flake8suppressions are no longer needed and can be removed even without changing any Python code. This PR removes them, as well as the comments that were present to explain them. Other comments are retained. I've also reformatted the pre-commit and flake8-specific configuration files for readability.In #1673 I mentioned I didn't plan to do anything more with
flake8before trying to replace it withruff, but I realized that these changes make the configuration simpler and shorter. (They may also make a switch toruff, if/when it is done, easier, because there are fewer suppression to look up how to do. But I am not asking that this PR be evaluated on that basis.)