Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation to code split by route and measure impact #457

Merged
merged 10 commits into from Jan 30, 2019

Conversation

kmjennison
Copy link
Contributor

  • Add a built-in measurement of "time to interactive" using Google's TTI polyfill
  • Update react-router-dom to a beta to fix a bug with React's lazy
  • Add source-map-explorer to inspect our bundles
    • We may want to try others, too, like Bundle Buddy, etc.
  • Move Firebase app initialization to root.js
  • Move Route.js into root.js for simplicity

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #457 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage    53.1%   53.05%   -0.05%     
==========================================
  Files         250      249       -1     
  Lines        6783     6789       +6     
  Branches     1190     1191       +1     
==========================================
  Hits         3602     3602              
- Misses       2518     2523       +5     
- Partials      663      664       +1
Impacted Files Coverage Δ
web/src/index.js 0% <ø> (ø) ⬆️
web/src/js/root.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e4b6c...1bd113b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #457 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage    53.1%   53.05%   -0.05%     
==========================================
  Files         250      249       -1     
  Lines        6783     6789       +6     
  Branches     1190     1191       +1     
==========================================
  Hits         3602     3602              
- Misses       2518     2523       +5     
- Partials      663      664       +1
Impacted Files Coverage Δ
web/src/index.js 0% <ø> (ø) ⬆️
web/src/js/root.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e4b6c...1bd113b. Read the comment docs.

@kmjennison kmjennison merged commit 0b125e7 into master Jan 30, 2019
@kmjennison kmjennison deleted the kevin/code-split-routes branch January 30, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React.lazy makes Route's proptypes fail
1 participant