Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load some non-critical resources on the new tab #461

Merged
merged 5 commits into from Feb 1, 2019

Conversation

kmjennison
Copy link
Contributor

Lazy load:

  • react-sparkle
  • the campaign component
  • the bookmark edit dialog

There's likely more we can lazy-load, such as the popover menus on the top-right and perhaps the actual widget components themselves.

I disabled some tests because Enzyme doesn't yet support React.Suspense and React.lazy. Let's reenable these tests when Enzyme adds support.

@kmjennison kmjennison merged commit 5888130 into master Feb 1, 2019
@kmjennison kmjennison deleted the kevin/newtab-lazy-load branch February 1, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant