fix: invalid parsing of traitalias

[alexander-akait]

• Refactor code using read_* for better maintenance
• Fix parsing:

class MyClass1 {
    use HelloWorld { sayHello as abstract private test; }
}

It is invalid and should not be parsable.

• Tests

[alexander-akait]

Need refactor too, let's do it in next PRs

[alexander-akait]

Expected because it is not grammatical problem, i think we should remove this check in future, we are parser not virtual machine for execution, so all runtime errors should be parsable

[ichiriac]

Hi @evilebottnawi,

I'm not agree with you - with this change you validate every invalid PHP token that is checked on runtime level over the AST.

Take this example : interface foo { abstract function bar(); } - in PHP it will allways trigger an fatal error.

I thing we should consider the 2 approaches :

1- first would be to parse the grammar as you indicate and forget runtime checks. That would imply you can not rely on the library to check the PHP syntax, and we would need an external tool for linting the resulting AST (including PHP runtime checks)

2- or handle that kind of problem directly into the parser as it was done since, and use a gracefull mode to ignore any syntax error

As nobody wants to handle broken PHP syntax, and if you need to parse it anyway you have a graceful flag for this, I prefer to keep extra runtime checks on the parser level.

The reason for me it's about syntax rules - it has no meaning to have an interface with an abstract function, PHP does not permit it anyway.

I think they gave an incomplete or simplified version of the grammar (due to simplifications or technical issues) so PHP needs extra check on runtime to filter syntax errors.

By not filtering every syntax errors (based on php documentation and not only on grammar file) you have a sort of graceful mode on various grammar problems, only justified by implementation choices of Zend team...

Lets do it like before, it's not about VM, it's about valid syntax or not, if it's not, you need to trigger an error

[coveralls]

Coverage decreased (-0.06%) to 95.806% when pulling 8741d13 on fix-and-refactor-trait-parsing into 0df5a49 on master.

[ichiriac]

Hi @evilebottnawi,

I'm not agree with you - with this change you validate every invalid PHP token that is checked on runtime level over the AST.

Take this example : interface foo { abstract function bar(); } - in PHP it will allways trigger an fatal error.

I thing we should consider the 2 approaches :

1- first would be to parse the grammar as you indicate and forget runtime checks. That would imply you can not rely on the library to check the PHP syntax, and we would need an external tool for linting the resulting AST (including PHP runtime checks)

2- or handle that kind of problem directly into the parser as it was done since, and use a gracefull mode to ignore any syntax error

As nobody wants to handle broken PHP syntax, and if you need to parse it anyway you have a graceful flag for this, I prefer to keep extra runtime checks on the parser level.

The reason for me it's about syntax rules - it has no meaning to have an interface with an abstract function, PHP does not permit it anyway.

I think they gave an incomplete or simplified version of the grammar (due to simplifications or technical issues) so PHP needs extra check on runtime to filter syntax errors.

By not filtering every syntax errors (based on php documentation and not only on grammar file) you have a sort of graceful mode on various grammar problems, only justified by implementation choices of Zend team...

Lets do it like before, it's not about VM, it's about valid syntax or not, if it's not, you need to trigger an error

[ichiriac]

Hi @evilebottnawi, not sure what to do with this PR, can we review it on 3.1 or does it introduce breaking changes ?

[alexander-akait]

Yes, let's do it in 3.1