Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor process exit interceptor #12

Merged
merged 1 commit into from
Sep 21, 2015
Merged

refactor process exit interceptor #12

merged 1 commit into from
Sep 21, 2015

Conversation

just-boris
Copy link
Contributor

  • patch process.exit only if we have streams needed to be flushed before exit
  • preserve exit code while awaiting streams

closes #11

@just-boris
Copy link
Contributor Author

Also, note that verify on markdown reporter is failing because of mochajs/mocha#1875

@glenjamin
Copy link
Owner

Looks like mocha 2.3.3 is almost released which will fix that markdown issue. Going to wait for that to get a green build and merge this.

* patch process.exit only if we have streams needed to be flushed before exit
* preserve exit code while awaiting streams
@just-boris
Copy link
Contributor Author

@glenjamin done, build is passing now

glenjamin added a commit that referenced this pull request Sep 21, 2015
refactor process exit interceptor
@glenjamin glenjamin merged commit 735ec32 into glenjamin:master Sep 21, 2015
@glenjamin
Copy link
Owner

Released as v0.7.2

@just-boris
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit code is always 0
2 participants