Replace Silex with HttpKernel Component #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on example from http-kernel documentation https://symfony.com/doc/current/4.4/http_kernel.html#a-full-working-example
Just to stop reporting error
|
This would be great to see it get over the finish line as silex is no longer supported. And while we're at it, PHP 8 support might be good as well. |
|
have you tested does this work? i don't recall where I left at, but I think it mostly works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on an example from http-kernel documentation
This drops setupErrorHandler, as
error()is complex to implement (need to duplicate quite some logic from Silex), and not really needed in this project.