Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make arrays optional when they should be in swift #2229

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Make arrays optional when they should be in swift #2229

merged 1 commit into from
Apr 26, 2023

Conversation

pagr
Copy link
Contributor

@pagr pagr commented Mar 29, 2023

No description provided.

@johanrydenstam
Copy link
Contributor

This is a very good addition!

@dvdsgl
Copy link
Member

dvdsgl commented Apr 25, 2023

Thank you @pagr — can you please explain the change?

@pagr
Copy link
Contributor Author

pagr commented Apr 26, 2023 •
edited

This fixes the issue where optional arrays from graphql are decoded as non optional arrays in swift.

Previously the graphQL type [String!] would be decoded as swift [String] but now it will correctly be decoded as swift [String]?

@dvdsgl dvdsgl merged commit f1d7a94 into glideapps:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pagr @johanrydenstam @dvdsgl