Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript zod #2238

Merged
merged 10 commits into from
Apr 25, 2023
Merged

Typescript zod #2238

merged 10 commits into from
Apr 25, 2023

Conversation

ryoid
Copy link
Contributor

@ryoid ryoid commented Apr 9, 2023

Made some fixes from #1771

There are 2 main issues I noticed so far

  • When comparing diff via schema, the key that is used for the name of types is different. Seems to be first occurrence for schema, last for JSON (0cffa.json)
  • Generated schemas sometimes references types that are defined after (spotify-album.json)
  • Also, properly handling top-level arrays

Not sure how to address these problems, skipped these tests for now. Might look into it when I have time, but would appreciate any help.

@dvdsgl
Copy link
Member

dvdsgl commented Apr 11, 2023

@ryoid thank you! Please see build error.

@ryoid
Copy link
Contributor Author

ryoid commented Apr 14, 2023

@ryoid thank you! Please see build error.

Updated!

@dvdsgl dvdsgl merged commit b7b9772 into glideapps:master Apr 25, 2023
23 checks passed
@dvdsgl
Copy link
Member

dvdsgl commented Apr 25, 2023

Thank you @ryoid and @Southclaws !

@Southclaws
Copy link

Oh this is awesome to see, thanks for finishing off what I started!

@kriswest
Copy link
Contributor

Generated schemas sometimes references types that are defined after (spotify-album.json)

They do indeed! #2414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants