Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve ReadableStream types issue in test suite #2581

Merged
merged 6 commits into from Apr 28, 2024

Conversation

inferrinizzard
Copy link
Contributor

@inferrinizzard inferrinizzard commented Apr 28, 2024

Description

Related to #2573.
GH Actions CI uses a browser fetch instead of Node-based fetch so the response.body will return as WebStreams.ReadableStream instead of NodeJS.ReadableStream from cross-fetch.

Only allows CI to use cross-fetch instead.

Motivation and Context

Resolves a types issue occurring in GH CI Pipeline

Previous Behaviour / Output

N/a

New Behaviour / Output

N/aa

How Has This Been Tested?

  • Test Suite passes

Screenshots (if appropriate):

@dvdsgl dvdsgl merged commit 49e9e03 into glideapps:master Apr 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants