Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: #issue-141 fix incorrect render issue of template tag #142

Closed
wants to merge 1 commit into from
Closed

bugfix: #issue-141 fix incorrect render issue of template tag #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/@glimmerx/storybook/src/client/preview/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,19 @@ export default function renderMain({ storyFn, showMain }: RenderMainArgs) {
glimmerStoryComponent = storyFnResult;
}

/**
* Fix an issue with template tag where the actual element is inserted as a sibling instead of being a child of #document-fragment
* Wrap this inside of window.onload for the iframe to finish
*/
window.addEventListener('load', () => {
rootElement.querySelectorAll('template').forEach((element: HTMLTemplateElement) => {
const { firstElementChild } = element;
if (firstElementChild) {
element.content.append(firstElementChild);
}
});
});

rootElement.innerHTML = '';
showMain();
return renderComponent(glimmerStoryComponent, glimmerRenderComponentOptions);
Expand Down