Update lints ahead of #1462, so that #1462's diff is smaller #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
NullVoxPopuli
force-pushed
the
update-lint-dependencies
branch
from
88d791b
to
4ab36a0
Compare
NullVoxPopuli
force-pushed
the
update-lint-dependencies
branch
from
a9bf6ca
to
d93661e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts lint dependency updates from #1462 to reduce #1462's diff.
This may cause conflicts, but they'd only be in the package.jsons or lockfile.
Also, notes were added to the .eslintrc.cjs' that would re-enable lints that are known to be fixed in #1462, as the updated lint dependencies made some things more strict.
Something I noticed is that there is a difference in expected behavior with
lints, and turbo's usage in this repo.
mainly every way of doing:
(for any package)
fails without eslint being in each package.json
So eslint has been added to every package.
Also, due to: actions/setup-node#865
I've forced node 20 in ci