add element parts, startTag & endTag #1553
Conversation
patricklx
force-pushed
the
html-tag-split
branch
2 times, most recently
from
3210d83
to
38bec77
Compare
| </Foo> | ||
| `); | ||
|
|
||
| let [, section] = ast.body; |
There was a problem hiding this comment.
what's the first node?
There was a problem hiding this comment.
Not sure, copied from tests above. Probably text node
| locEqual(section.endTag, 5, 4, 5, 10, 'Foo end tag'); | ||
| let [, barSelfClosed] = section.children; | ||
| if (assertNodeType(barSelfClosed, 'ElementNode')) { | ||
| locEqual(barSelfClosed.parts[0], 3, 7, 3, 10, 'bar.x.y bar part'); |
There was a problem hiding this comment.
do each of these have their part name attached? if so, it would be good to assert that as well.
patricklx
force-pushed
the
html-tag-split
branch
from
38bec77
to
b4e31f5
Compare
patricklx
force-pushed
the
html-tag-split
branch
from
8e4690b
to
c7682c5
Compare
| value: string; | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
beautiful, thank you!
| `); | ||
|
|
||
| let [, foo] = ast.body; | ||
| locEqual(foo, 2, 4, 5, 10, 'Foo element'); |
There was a problem hiding this comment.
is this range right? 4 to 10 is 6, but the element is <Foo as |bar|> ~ 14
There was a problem hiding this comment.
the end is at </Foo>, so this is correct. the element is the whole thing, from <Foo to </Foo>
There was a problem hiding this comment.
what is the range of 6 though? feels ... arbitrary? I'm probably missing something though.
There was a problem hiding this comment.
start: line 2, column 4
end: line 5, column 10
different line
| let [, foo] = ast.body; | ||
| locEqual(foo, 2, 4, 5, 10, 'Foo element'); | ||
| if (assertNodeType(foo, 'ElementNode')) { | ||
| locEqual(foo.startTag, 2, 4, 2, 18, 'Foo start tag'); |
Provide source spans for the open and close tags without adding new AST nodes, also parse the element's tag name into a path which has the required source span.
part of #1490