Restore test harness on CI #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test harness haven't been accurately reporting failures, this restores it.
chancancode
force-pushed
the
fix-tests
branch
from
522ec1c
to
5f8ab8c
Compare
This reverts commit e099bd9. `Math.max()` and `>` have different reuslts for `NaN` which is used by volatile tag. This is caught by tests but wasn't reported in the harness correctly. I suspect we can drop volatile tags, I am pretty sure Ember doesn't use it anymore. However that would require some work to clean up probably. The original commit was merged permaturely anyway. We may be able to re-land a targeted version of that commit, with better testing, once/if volatile tags are removed.
NullVoxPopuli
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test harness haven't been accurately reporting failures, this restores it.