Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor on modifier implementation #1573

Merged
merged 1 commit into from Mar 8, 2024
Merged

Conversation

chancancode
Copy link
Contributor

No description provided.

@@ -239,7 +298,7 @@ function addEventListener(
@method on
@public
*/
class OnModifierManager implements InternalModifierManager<OnModifierState | null, object> {
class OnModifierManager implements InternalModifierManager<OnModifierState, object> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's so nice now!!

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thanks for walking through some of this on discord!!

@NullVoxPopuli NullVoxPopuli merged commit 92e150d into main Mar 8, 2024
6 checks passed
@NullVoxPopuli NullVoxPopuli deleted the refactor-on-modifier branch March 8, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants