Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent use of ...attributes in invalid places #1582

Merged
merged 3 commits into from Mar 25, 2024
Merged

Prevent use of ...attributes in invalid places #1582

merged 3 commits into from Mar 25, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Mar 25, 2024 •
edited

This should allow us to delete some code in ember.js, as ...attributes in {{}} is always invalid.

The underlying parser already errors for .foo and foo..bar

@chancancode chancancode merged commit be49ccd into main Mar 25, 2024
5 of 6 checks passed
@chancancode chancancode deleted the throw-on-attributes-in-the-wrong-place branch March 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancancode chancancode chancancode approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NullVoxPopuli @chancancode