Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnsureIndexes to allow batch creation of indexes #312

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

fuzzypete
Copy link

Ok.. attempt #2

@eminano
Copy link

eminano commented Jan 16, 2019

This PR addresses issue #310

Copy link

@eminano eminano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, just a small comment. Thanks for taking the time, and sorry for the delay!

LanguageOverride: index.LanguageOverride,
Collation: index.Collation,
PartialFilterExpression: index.PartialFilter,
logicalKeyName: keyInfo.name,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logicalKeyName is the same as Name, so you can use that instead.
Alternatively, you could store the cache key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants