Support for setting working_dir and sandboxing in GlobusComputeEngine
#1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadudoc
requested review from
ryanchard,
rjmello,
joshbryan-globus and
khk-globus
yadudoc
force-pushed
the
gce_working_dir
branch
2 times, most recently
from
b455999
to
5ad865f
Compare
khk-globus
reviewed
Apr 30, 2024
yadudoc
force-pushed
the
gce_working_dir
branch
from
5ad865f
to
d2d13b2
Compare
khk-globus
reviewed
May 1, 2024
yadudoc
force-pushed
the
gce_working_dir
branch
2 times, most recently
from
071a772
to
bf3fd11
Compare
|
@khk-globus Recommend adding a test on the endpoint interchange to confirm that the run_dir is set appropriately. |
khk-globus
force-pushed
the
gce_working_dir
branch
from
585a07d
to
17d841c
Compare
khk-globus
approved these changes
May 30, 2024
|
[sc-32391] |
* Functions run in `GCE.working_dir` if specified.
* If `GCE.working_dir` is not specified or set to None, functions default to
running in the endpoint_dir which defaults to
`~/.globus_compute/<endpoint_name>`
* If `GCE.run_in_sandbox` is enabled, functions run in
`working_dir/<task_uuid>`. This option is disabled by default.
* Specify this option via config.yaml like:
```yaml
.. code-block:: yaml
engine:
type: GlobusComputeEngine
working_dir: /tmp/foo
run_in_sandbox: True
```
[sc-32391]
khk-globus
force-pushed
the
gce_working_dir
branch
from
17d841c
to
966011b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the endpoints using
GCEwould have functions run in the directory from which the endpoint was started rather than some well-defined location. This PR adds support for setting aworking_diroption toconfigure function's working directory and for functions that create files a new sandboxing feature is added. Setting
run_in_sandbox: Trueeach function executes in a sandbox directory set to function_uuid as the name.Here's a config example:
[sc-32391]
Type of change
Choose which options apply, and delete the ones which do not apply.