feat(Authorization): adds "additionalParams" option to allow passing arbitrary query parameters through OAuth redirects. #170
+114
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just learning about the test suite so I can test the params are preserved |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 99.12% 91.80% -7.33%
==========================================
Files 63 63
Lines 919 927 +8
Branches 125 132 +7
==========================================
- Hits 911 851 -60
- Misses 8 68 +60
- Partials 0 8 +8 ☔ View full report in Codecov by Sentry. |
jakeglobus
force-pushed
the
add-overrides-for-auth-params
branch
from
fff6292
to
0d29c28
Compare
jakeglobus
force-pushed
the
add-overrides-for-auth-params
branch
2 times, most recently
from
7ac60ee
to
e07ba94
Compare
|
Still trying to figure out what test for |
jbottigliero
changed the title
jakeglobus
force-pushed
the
add-overrides-for-auth-params
branch
from
d5fe7b0
to
8a48b7a
Compare
Co-authored-by: Joe Bottigliero <694253+jbottigliero@users.noreply.github.com>
…ects - The `additionalParams` option is for the transport, not the `getToken` method.
jbottigliero
force-pushed
the
add-overrides-for-auth-params
branch
from
f69c80b
to
87c9533
Compare
This was referenced Jun 3, 2024
jbottigliero
pushed a commit
that referenced
this pull request
Jun 3, 2024
## [3.4.0](v3.3.1...v3.4.0) (2024-06-03) ### Features * **Authorization:** adds `additionalParams` option to allow passing arbitrary query parameters through OAuth redirects. ([#170](#170)) ([754b508](754b508)) ```tsx managerInstance.handleErrorResponse(res, { additionalParams: { retained_state: "example-state", retained_route: "example.route", }, }); ``` * **GCS:** adds HTTPS Access service methods to GCS ([#182](#182)) ([a258082](a258082)) ```tsx const request = await https.get(GCS_CONFIGURATION, '/my-file.txt', { headers: { Authorization: 'Bearer an-example-token', }, }); ``` ## Internal We've updated the request composition to include an `X-Globus-ClientInfo` header with requests. This header will include the current SDK version information for use by the Globus platform and support. e.g. `X-Globus-ClientInfo: product=javascript-sdk,version=3.4.0;`. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.