fix: Adding non-default loggables explicitly.

hoomd/logging.py

@@ -624,12 +624,16 @@ def only_default(self):
         quantities."""
         return self._only_default
 
-    def _filter_quantities(self, quantities):
+    def _filter_quantities(self, quantities, force_quantities=False):
         for quantity in quantities:
-            if self._only_default and not quantity.default:
+            if quantity.category not in self._categories:
                 continue
-            elif quantity.category in self._categories:
+            # Must be before default check to overwrite _only_default
+            if force_quantities:
                 yield quantity
+            if self._only_default and not quantity.default:
+                continue
+            yield quantity
 
     def _get_loggables_by_name(self, obj, quantities):
         if quantities is None:
@@ -643,7 +647,7 @@ def _get_loggables_by_name(self, obj, quantities):
                     "object {} has not loggable quantities {}.".format(
                         obj, bad_keys))
             yield from self._filter_quantities(
-                map(lambda q: obj._export_dict[q], quantities))
+                map(lambda q: obj._export_dict[q], quantities), True)
 
     def add(self, obj, quantities=None, user_name=None):
         """Add loggables from obj to logger.

hoomd/pytest/test_logging.py

@@ -56,6 +56,10 @@ def prop(self):
     def proplist(self):
         return [1, 2, 3]
 
+    @log(category="string", default=False)
+    def prop_nondefault(self):
+        return "foo"
+
     def __eq__(self, other):
         return isinstance(other, type(self))
 
@@ -242,7 +246,7 @@ def test_get_loggables_by_names(self, blank_logger, logged_obj):
         ])
 
         # Check when quantities is given
-        accepted_quantities = ['prop', 'proplist']
+        accepted_quantities = ['proplist', "prop_nondefault"]
         log_quanities = blank_logger._get_loggables_by_name(
             logged_obj, accepted_quantities)
         assert all([
@@ -275,10 +279,9 @@ def test_add(self, blank_logger, logged_obj, base_namespace):
 
         # Test multiple quantities
         blank_logger._dict = dict()
-        blank_logger.add(logged_obj, ['prop', 'proplist'])
-        expected_namespaces = [
-            base_namespace + ('prop',), base_namespace + ('proplist',)
-        ]
+        loggables = ['prop', 'proplist', "prop_nondefault"]
+        blank_logger.add(logged_obj, loggables)
+        expected_namespaces = [base_namespace + (name,) for name in loggables]
         assert all([ns in blank_logger for ns in expected_namespaces])
         assert len(blank_logger) == 2