Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unclickable images in tickets followups #16916

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix unclickable images in tickets followups #16916

wants to merge 1 commit into from

Conversation

RomainLvr
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets !31348

image

Before:
image

After:
image

@RomainLvr RomainLvr marked this pull request as draft April 10, 2024 13:53
@RomainLvr RomainLvr self-assigned this Apr 10, 2024
cedric-anne
cedric-anne reviewed May 21, 2024
View reviewed changes
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment, we do not convert images having a http(s) URI. I am not sure we should support it.

Anyway, this is not a bug, and changing it should target the main branch.

@RomainLvr RomainLvr changed the base branch from 10.0/bugfixes to main May 21, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-anne cedric-anne cedric-anne left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@RomainLvr RomainLvr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RomainLvr @cedric-anne