Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planning Twig UI #16947

Merged
merged 1 commit into from
May 27, 2024
Merged

Planning Twig UI #16947

merged 1 commit into from
May 27, 2024

Conversation

cconard96
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

@cconard96 cconard96 added the ui label Apr 19, 2024
@cconard96 cconard96 force-pushed the ui/planning branch 2 times, most recently from 37a4faa to 5dd92c9 Compare April 29, 2024 17:57
cedric-anne
cedric-anne requested changes May 16, 2024
View reviewed changes
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not take time to test all the features, but I found some issues.

  1. Selecting a start time / duration with the mouse in order to create an event does not work anymore (the preselected values are always the current time and a 1h duration).

  2. The external event form in the modal is not displayed correctly (fields are really small).
    image

@cedric-anne cedric-anne self-requested a review May 21, 2024 11:56
cedric-anne
cedric-anne approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems technically OK, but I did not take time to test all the features.

@trasher
Copy link
Contributor

trasher commented May 24, 2024

Could you please rebase to solve conflicts?

@cedric-anne cedric-anne merged commit bb82202 into glpi-project:main May 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@orthagh orthagh Awaiting requested review from orthagh

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cconard96 @trasher @cedric-anne @AdrienClairembault