Auth Twig UI (Part 1) #16951
Merged
Auth Twig UI (Part 1) #16951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconard96
force-pushed
the
ui/auth
branch
2 times, most recently
from
91b0dd2
to
74d6e8b
Compare
cedric-anne
reviewed
May 21, 2024
| }) }} | ||
|
|
||
| {{ fields.dropdownYesNo('use_bind', item.fields['use_bind'], __('Use bind'), { | ||
| helper: __("Indicates whether a simple bind operation should be used during connection to LDAP server. Disabling this behaviour can be required when LDAPS bind is used.")|e('html') |
There was a problem hiding this comment.
The helper is already in the target macro.
Suggested change
| helper: __("Indicates whether a simple bind operation should be used during connection to LDAP server. Disabling this behaviour can be required when LDAPS bind is used.")|e('html') | |
| helper: __("Indicates whether a simple bind operation should be used during connection to LDAP server. Disabling this behaviour can be required when LDAPS bind is used.") |
There was a problem hiding this comment.
The field helpers allow HTML content, but we wouldn't want to accidentally add HTML content from a localization.
|
|
||
| {{ fields.textField('login_field', item.fields['login_field'], __('Login field'), field_options) }} | ||
| {{ fields.textField('sync_field', item.fields['sync_field'], __('Synchronization field'), { | ||
| helper: __('Synchronization field cannot be changed once in use.')|e('html'), |
There was a problem hiding this comment.
Suggested change
| helper: __('Synchronization field cannot be changed once in use.')|e('html'), | |
| helper: __('Synchronization field cannot be changed once in use.'), |
Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
cedric-anne
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog for intended changes/removals/fixes.