-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity Assistance Tab UI + some AJAX #17023
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to solve conflicts.
8b5d442
to
18dc3a3
Compare
18dc3a3
to
3b974fd
Compare
b2af1e5
to
350687e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a fresh GLPI installation,
'suppliers_as_private' => $entity->getInheritedValueBadge('suppliers_as_private'), | ||
'anonymize_support_agents' => $entity->getInheritedValueBadge('anonymize_support_agents'), | ||
'display_users_initials' => $entity->getInheritedValueBadge('display_users_initials'), | ||
'contracts_id_default' => $entity->getInheritedValueBadge('contracts_id_default', 'contracts_strategy_default'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false | ||
), | ||
'entities_id_software' => $entity->getInheritedValueBadge('entities_id_software', 'entities_strategy_software'), | ||
'transfers_id' => $entity->getInheritedValueBadge('transfers_id', 'transfers_strategy'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false, | ||
false | ||
), | ||
'entities_id_software' => $entity->getInheritedValueBadge('entities_id_software', 'entities_strategy_software'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'toadd' => $autopurge, | ||
'unit' => 'day' | ||
$inheritance_labels = [ | ||
'tickettemplates_id' => $entity->getInheritedLinkedValueBadge(TicketTemplate::class), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know if nothing, -----
, or None
is the best label to display. Anyways, it should be done the same for all options.
ajax/commonitilsatisfaction.php
directly.ajax/commonitilsatisfaction.php
to Twig.concat_ws
to QueryFunction class