Handle some deprecation/removal notes for GLPI 11.0 #17108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
reviewed
May 14, 2024
cedric-anne
reviewed
May 14, 2024
cedric-anne
force-pushed
the
task/planned_deprecation_removals
branch
from
5bb165d
to
7ea17fb
Compare
cedric-anne
approved these changes
May 22, 2024
There was a problem hiding this comment.
I reverted some changes related to methods/classes that are used by many plugins. They correspond to simple methods/classes that are not complex to maintain. It is OK to have a few deprecated lines of code if it helps plugins developpers to upgrade their code to GLPI 11.0.
The Ticket_Ticket::getLinkedTicketsTo() seems to be used in one of our templates. It has to be fixed, in another PR. I am not sure that the new method produces the exact same result and the template may need to be adapted.
The methods that are removed here without any deprecation phase are almost not used in plugins, and in all cases, it is easier to update the plugins code rather than maintain the previous behaviour.
orthagh
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of unresolved deprecation/removal notes for GLPI 11.0. As GLPI 11 is a major version, breaking changes should be expected so deprecations are probably not needed in most cases. This PR addresses some of the notes, but there are still a lot remaining.