Form access control: access decision stategy (affirmative/unanimous) #17117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
reviewed
May 15, 2024
There was a problem hiding this comment.
As far as I understand, unanimous will be the default decision strategy. With only the 2 current access control strategies, it does not make sense. Indeed, having both "allows anonymous" and "requires a specific profile" will never match together with the user context. Unless we plan to add new access control strategies, the default decision strategy should probably be affirmative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow forms policies to be computed in an affirmative/unanimous way.
(Suggested by @cedric-anne here: #16836).
Possible values:
Tooltip explaining the values:
To implement this, I've had to rework the twig template containing the access control configuration forms as it was built to update only update policies and the new setting is store into the form object itself.