Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support non-recursive cte #1052

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

ding-young
Copy link
Contributor

@ding-young ding-young commented Jan 1, 2023

Related Issue

#393

Questions..

  • entrypoint for translation?
  • cte alias
  • cte inside tablefactor::derived
WITH cte1 AS (SELECT 1)
SELECT * FROM (WITH cte2 AS (SELECT 2) SELECT * FROM cte2 JOIN cte1) AS dt;

TODO

  • add more test case
  • refactor..
  • remove unnecessary clone

replace reference to cte with derived tables in translate layer
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3816656986

  • 227 of 231 (98.27%) changed or added relevant lines in 2 files are covered.
  • 33 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 98.514%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/translate/query.rs 86 90 95.56%
Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 33 82.72%
Totals Coverage Status
Change from base Build 3781832138: -0.08%
Covered Lines: 37998
Relevant Lines: 38571

💛 - Coveralls

@panarch panarch added the enhancement New feature or request label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants