Implement Memory transaction #1392
Open
+256
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this draft pull request, i used naive approach, which is called as 'snapshot' to memoize previous state. With this strategy, the transaction implementation follows few steps 1. capture a snapshot of the current state of memory storage at the moment when a transaction starts 2. In transaction trait impl block, it checks what the current storage transacion state is 2.a - If there is no transaction and it is not autocommit, memory storage set snapshot and begin process 2.b - If there is no transaction and a incoming transaction is autocommit, mem storage doens't memorize snapshot and just do the process right away 2.c - If there is a transaction being processed already, mem storage abort the incoming storage in this phase 3. If there is a rollback request during transaction process, mem storage use snapshot to recover data and set 'None' to snapshot field. 4. If there is a commit request, mem storage decided to end of transaction and reflect the changes into storage 5. In both cases of rollback request and commit request, we set transaction state of a mem storage as 'Idle' again so that it can handle future transactions
- error.rs - stage.rs
I removed snapshot file because implementation of action-based transaction is done at this moment.
…ucture Log-based datastructure is basically simple stack structure It stores logs of statement execution and a set of data related to the statement.
github-actions
bot
requested review from
devgony,
ever0de,
panarch and
zmrdltl
Pull Request Test Coverage Report for Build 6036564413
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #373
Memory transaction support to resolve issue #373.
Implementation details and changes are below:
p.s. I deleted commits in my forked repository by mistake and the previous pull request #1360 was closed unexpectedly.