geo-replication: replace logging.warn with logging.warning (#4344) #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
/run regression |
|
0 test(s) failed 1 test(s) generated core 1 test(s) needed retry |
aravindavk
requested changes
Apr 29, 2024
| @@ -542,7 +542,7 @@ def crawlwrap(self, oneshot=False, register_time=None): | |||
| rconf.volume_id = self.uuid | |||
| if self.volinfo: | |||
| if self.volinfo['retval']: | |||
| logging.warn(lf("primary cluster's info may not be valid", | |||
| logging.warning(lf("primary cluster's info may not be valid", | |||
There was a problem hiding this comment.
Next line is not indented properly
| @@ -1169,7 +1169,7 @@ def process_change(self, change, done, retry): | |||
| entries.append( | |||
| edct(ty, stat=st, entry=en, gfid=gfid, link=rl)) | |||
| else: | |||
| logging.warn(lf('ignoring op', | |||
| logging.warning(lf('ignoring op', | |||
There was a problem hiding this comment.
same here and check for all the changes.
jelly
force-pushed
the
cleanup-logging-warn
branch
from
eb063af
to
55a79a5
Compare
aravindavk
approved these changes
May 3, 2024
|
/run regression |
Shwetha-Acharya
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging.warn is an alias to logging.warning since Python 3.3 and will be removed in Python 3.13.