Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Expo 51 and Cocoapods 1.15.2 #75

Merged
merged 2 commits into from
May 22, 2024

Conversation

D4ryl00
Copy link
Contributor

@D4ryl00 D4ryl00 commented May 17, 2024

This PR updates dSocial to the latest version of:

  • GnoNative (with Expo 51)
  • Expo 51
  • Cocoapods 1.15.2

Expo 51 uses React Native 0.74 which uses Java 17 (see here): If you have already installed JDK on your system, we recommend JDK 17. You may encounter problems using higher JDK versions.

The previous version used was Java 18 which created a conflict between the two versions: Inconsistent JVM-target compatibility detected for tasks 'compileDebugJavaWithJavac' (17) and 'compileDebugKotlin' (18).

Finally, this PR also removes the native folders and adds them in the .gitignore files because they are automatically created npx expo run:ios (or android), following the recommendations of npx expo-doctor@latest.

@D4ryl00 D4ryl00 requested review from iuricmp and jefft0 May 17, 2024 11:07
@D4ryl00 D4ryl00 self-assigned this May 17, 2024
@jefft0
Copy link
Contributor

jefft0 commented May 17, 2024

make android gives the error:

Error: /Users/jefft0/temp/dsocial/mobile/android/gradlew app:assembleDebug -x lint -x test --configure-on-demand --build-cache -PreactNativeDevServerPort=8081 -PreactNativeArchitectures=arm64-v8a exited with non-zero code: 1
    at ChildProcess.completionListener (/Users/jefft0/temp/dsocial/mobile/node_modules/@expo/spawn-async/build/spawnAsync.js:42:23)
    at Object.onceWrapper (node:events:634:26)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)
    ...
    at spawnAsync (/Users/jefft0/temp/dsocial/mobile/node_modules/@expo/spawn-async/build/spawnAsync.js:7:23)
    at spawnGradleAsync (/Users/jefft0/temp/dsocial/mobile/node_modules/@expo/cli/build/src/start/platforms/android/gradle.js:96:48)
    at assembleAsync (/Users/jefft0/temp/dsocial/mobile/node_modules/@expo/cli/build/src/start/platforms/android/gradle.js:74:18)
    at runAndroidAsync (/Users/jefft0/temp/dsocial/mobile/node_modules/@expo/cli/build/src/run/android/runAndroidAsync.js:45:37)

Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and iOS simulators.

@D4ryl00 D4ryl00 merged commit fe638ae into gnolang:main May 22, 2024
@D4ryl00 D4ryl00 deleted the chore/bump-expo-51 branch May 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants