-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add gnolang/faucet
#2122
base: master
Are you sure you want to change the base?
docs: add gnolang/faucet
#2122
Conversation
Posted some questions here to clarify things not found in the reference docs |
Crossposting from the issue for visibility:
What is the difference between these flags?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link to the accompanying docs.gno.land
PR in the description, and add adequate labels 🙏
Also, please update the PR description to have a bit more details
- `gnoland` & `gnokey` installed | ||
- A Gno.land keypair generated using [`gnokey`](../gno-tooling/cli/gnokey.md) | ||
|
||
## Premining funds to an address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should drop this section completely, and not reference genesis_balances.txt
anywhere -- we have adequate genesis balances
commands for premining accounts
|
||
## Premining funds to an address | ||
|
||
Before setting up the faucet, we need to make sure that the address will be used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a correct English sentence:
we need to make sure that the address will be used to serve the funds contain enough testnet funds
|
||
```json | ||
{ | ||
"To": "g1juz2yxmdsa6audkp6ep9vfv80c8p5u76e03vvh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outdated, please reference the latest gnolang/faucet
request structure
} | ||
``` | ||
|
||
You can test this out buy running the following `curl` command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here, buy
in the `--remote` flag in the faucet. If your node is listening on a separate | ||
address, make sure to match it accordingly when running the faucet. | ||
|
||
## Making faucet requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error handling was not covered in this section, please cover it 🙏
@@ -0,0 +1,46 @@ | |||
--- | |||
id: gno-tooling-tm2-faucet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the use of this file is, it can become outdated very quickly (help output)
@@ -0,0 +1,173 @@ | |||
--- | |||
id: setting-up-a-faucet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tutorial doesn't cover:
gnofaucet
gnofaucet
vsgnolang/faucet
- different things I've noted as part of the comments
Description
Closes: #2120
This PR introduces the following changes to the docs (text copied over from the issue linked above):
Matching docs PR (linked in the issue that this PR was created from)
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description