feat(examples): Implement p/demo/nonces #2123
Open
+124
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhpn99
requested review from
thehowl and
mvertes
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
moul
reviewed
May 22, 2024
moul
reviewed
May 22, 2024
| return currentNonce | ||
| } | ||
|
|
||
| // UseCheckedNonce consumes a nonce if it matches the expected value, otherwise returns an error |
There was a problem hiding this comment.
Could you explain how you intend to use this?
There was a problem hiding this comment.
I think this is a necessary additional check before actually consuming the nonce
There was a problem hiding this comment.
Reviewing your pull requests is challenging. Please avoid marking conversations as resolved on your own. Instead, focus on addressing the issues or providing responses so we can more easily conduct a second review.
cc @gnolang/devrels @zivkovicmilos
There was a problem hiding this comment.
I don't understand your answer. Can you provide a better explanation? An example?
moul
reviewed
May 22, 2024
moul
reviewed
May 22, 2024
moul
reviewed
May 22, 2024
moul
reviewed
May 22, 2024
moul
reviewed
May 22, 2024
moul
reviewed
May 22, 2024
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
…into add-package-nonces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From issue : #2119
A simple implementation of nonce manager in p/demo/nonces : Provides tracking nonces for addresses. Nonces will only increment.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description