Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

every X days should run on the same day if the At() time has yet to come #553

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

JohnRoesler
Copy link
Contributor

What does this do?

  • currently 7am, run a schedule for every 2 days at 9am and 11am -> should run at 9am and 11am on the day the scheduler was started
  • currently 12 noon, run a schedule for every 2 days at 9am and 11am -> should run at 9am and 11am two days after the scheduler started

Which issue(s) does this PR fix/relate to?

resolves #552

List any changes that modify/break current functionality

The initial scheduling of jobs using At time changed to be more intuitive (see the description above)

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@JohnRoesler JohnRoesler merged commit b86d02b into main Aug 29, 2023
6 checks passed
@JohnRoesler JohnRoesler deleted the fix-every-multiple-days branch August 29, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Every X days doesn't run At() time on the initial day
1 participant