Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more than 1 day before last day of month gets stuck in a loop #555

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

JohnRoesler
Copy link
Contributor

What does this do?

a bug was introduced in #542 that this PR fixes. when calculating the next run it didn't take into account multiple negative days and only considered the last day of the month

Which issue(s) does this PR fix/relate to?

resolves #554

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@JohnRoesler JohnRoesler merged commit d7dd276 into main Aug 30, 2023
6 checks passed
@JohnRoesler JohnRoesler deleted the fix-last-day-of-month branch August 30, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - MonthLastDay() and Month() with negative values stuck in infinite loop
1 participant