fix(scheduler): ensure negative intervals given to Every return an immediate error #600
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
reviewed
Oct 30, 2023
husam-e
commented
Oct 30, 2023
Co-authored-by: John Roesler <johnrroesler@gmail.com>
JohnRoesler
reviewed
Oct 30, 2023
scheduler_test.go
Outdated
| // do nothing | ||
| }) | ||
|
|
||
| require.EqualError(t, err, ErrInvalidInterval.Error()) |
There was a problem hiding this comment.
ah, the error is wrapped. So it's got another one around it. I think using require.ErrorIs should do it
There was a problem hiding this comment.
thanks, I actually removed these checks as I realized there was already a bad interval test case, so I added cases to that and switched it to use contain.
JohnRoesler
reviewed
Oct 30, 2023
JohnRoesler
reviewed
Oct 30, 2023
JohnRoesler
reviewed
Oct 30, 2023
JohnRoesler
reviewed
Oct 30, 2023
JohnRoesler
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Ensures negative intervals return an immediate error.
Which issue(s) does this PR fix/relate to?
Resolves #600
List any changes that modify/break current functionality
Negative intervals will now return an error.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
example_test.goREADME.mdNotes
Potentially breaking change for any consumer expecting negative intervals to not return an error.