dupSubExpr: rewrite with ruleguard #1081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
force-pushed
the
new-dupSubExpr
branch
from
4b341d6
to
6b00408
Compare
quasilyte
reviewed
Dec 26, 2021
| m.Match(`$x % $x`). | ||
| Report(`suspicious identical left and right expression near %`) | ||
|
|
||
| // TODO |
There was a problem hiding this comment.
What exactly this TODO means? :)
There was a problem hiding this comment.
AFAIR there were failures in expressions below...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly wip, not working by design with floats.