Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkers: add unassignedError #1108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

checkers: add unassignedError #1108

wants to merge 2 commits into from

Conversation

cristaloleg
Copy link
Member

No description provided.

un000
un000 previously approved these changes Oct 13, 2021
@un000
Copy link

un000 commented Oct 13, 2021

IP validation failed

	if net.ParseIP(ipAddr).To4() == nil {
		continue
	}

Workers loop failed:

func runWorker(ctx context.Context) {
	for {
		if ctx.Err() != nil {
			return
		}
		// ...
	}
}

@cristaloleg
Copy link
Member Author

As for me 2nd fail is pretty acceptable, regarding 1st - not sure. However making explicit error handling ('hey look, I'm checking error here, not something else') is more clear. WDYT ?

@quasilyte
Copy link
Member

This needs to be rebased and re-generated.
After that, we can merge it.

@quasilyte
Copy link
Member

Now we need to check the warnings for the external testdata.
If they're expected, they need to be added to the golden files (PR to the external testdata repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants