support linux-loong64 native debug #3685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoongArch is a new RISC ISA, which is independently designed by Loongson Technology. LoongArch includes a reduced 32-bit version (LA32R), a standard 32-bit version (LA32S) and a 64-bit version (LA64), and loong64 is the 64-bit version of LoongArch. LoongArch documentation: https://github.com/loongson/LoongArch-Documentation.git
|
The arch project hasn't been integrated into the upstream yet, so I duplicated it to the vendor and submitted it. |
aarzilli
reviewed
Mar 12, 2024
| @@ -80,7 +80,7 @@ func goBuildArgs(debugname string, pkgs []string, buildflags string, isTest bool | |||
|
|
|||
| args = append(args, "-o", debugname) | |||
| if isTest { | |||
| args = append([]string{"-c"}, args...) | |||
| args = append([]string{"-c", "-mod=vendor"}, args...) | |||
There was a problem hiding this comment.
We can't force users to only build with -mod=vendor.
| @@ -1,4 +1,4 @@ | |||
| //go:build linux && !amd64 && !arm64 && !386 && !(ppc64le && exp.linuxppc64le) | |||
| //go:build linux && !amd64 && !arm64 && !386 && !(ppc64le && exp.linuxppc64le) && !loong64 | |||
There was a problem hiding this comment.
Unless we can have a machine to run CI we shouldn't change this.
|
PS. also see test failures. |
abner-chenc
reviewed
Mar 13, 2024
| @@ -1,4 +1,4 @@ | |||
| //go:build (linux && amd64) || (linux && arm64) || (linux && ppc64le) | |||
| //go:build (linux && amd64) || (linux && arm64) || (linux && ppc64le) || (linux && loong64) | |||
There was a problem hiding this comment.
go:build (linux && (386 || ppc64le || loong64)) || (darwin && arm64) || (windows && arm64)
I think it's better this way
|
The x/arch has submitted a PR to support loong64, but it has not yet been merged into the upstream repository. I can provide machines running CI at any time. Thanks. |
|
That's cool, we'll have to wait for that PR to be merged for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoongArch is a new RISC ISA, which is independently designed by Loongson Technology.
LoongArch includes a reduced 32-bit version (LA32R), a standard 32-bit version (LA32S) and a 64-bit version (LA64), and loong64 is the 64-bit version of LoongArch.
LoongArch documentation: https://github.com/loongson/LoongArch-Documentation.git
Since version 1.19, golang upstream support for the LA architecture has been maintained.